I agree with the change. The handle_error jump does require framebuffer.base to be initialized. Doing the initialization at top of __glXDRIscreenProbe body is also a good idea - even if it could be initialized lower, doing it at top gives better chance of not repeating the mistake on further modifications. <div class="gmail_quote">2013/2/23 Piotr Dziwinski <<a href="mailto:piotrdz@gmail.com" target="_blank">piotrdz@gmail.com</a>> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Fixes: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=59825" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=59825</a> Signed-off-by: Piotr Dziwinski <<a href="mailto:piotrdz@gmail.com">piotrdz@gmail.com</a>> --- glx/glxdri.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/glx/glxdri.c b/glx/glxdri.c index da46468..a997e2f 100644 --- a/glx/glxdri.c +++ b/glx/glxdri.c @@ -971,6 +971,8 @@ __glXDRIscreenProbe(ScreenPtr pScreen) size_t buffer_size; ScrnInfoPtr pScrn = xf86ScreenToScrn(pScreen); + framebuffer.base = NULL; + if (!xf86LoaderCheckSymbol("DRIQueryDirectRenderingCapable") || !DRIQueryDirectRenderingCapable(pScreen, &isCapable) || !isCapable) { LogMessage(X_INFO, -- 1.8.1.3 _______________________________________________ <a href="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</a>: X.Org development Archives: <a href="http://lists.x.org/archives/xorg-devel" target="_blank">http://lists.x.org/archives/xorg-devel</a> Info: <a href="http://lists.x.org/mailman/listinfo/xorg-devel" target="_blank">http://lists.x.org/mailman/listinfo/xorg-devel</a> </blockquote></div>