On Sep 28, 2012 7:45 AM, "Adam Jackson" <<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>> wrote: > > On 9/27/12 7:13 PM, Keith Packard wrote: >> >> Adam Jackson <<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>> writes: >> >>> All this does is make it so editing <a href="http://configure.ac">configure.ac</a> or Makefile.am doesn't >>> rebuild the makefiles. Which is just stupid. >> >> >> At one point, I'm almost certain that not having AM_MAINTAINER_MODE >> meant that you *never* got correct behaviour. When did that change? > > > Maybe you're remembering "you need --enable-maintainer-mode to get correct behaviour"? Which is true, if you've said AM_MAINTAINER_MODE in <a href="http://configure.ac">configure.ac</a>. It's more correct for downstream in a sense. You don't accidentally get the autotools pulled in during your tarball build if you patched something. There are ways to accomplish that (touch) without maintainer mode, though. I recall Julien said they wanted this in Debian. I think this patch is the right thing to do. Reviewed-by: Dan Nicholson <<a href="mailto:dbn.lists@gmail.com">dbn.lists@gmail.com</a>>