<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2"> </HEAD> <BODY> On Thu, 2011-09-15 at 13:18 -0500, Jeremy Huddleston wrote: <BLOCKQUOTE TYPE=CITE> <PRE> Ok, then this gets my structural review, but would be nice if someone who really understands docbook looks at invocation. </PRE> </BLOCKQUOTE> I would love to as well. However, from a risk management perspective, this new version is mainly a reshuffle of make targets flags. I use an identical copy of docbook.am and devbook.am in the 22 modules having docbook xml. This way we don't have to review 22 differently coded makefiles performing the exact same programming tasks.<BR> <BR> Thanks <BLOCKQUOTE TYPE=CITE> <PRE> Reviewed-by: Jeremy Huddleston <<A HREF="mailto:jeremyhu@apple.com">jeremyhu@apple.com</A>> On Sep 15, 2011, at 8:41 AM, Gaetan Nadon wrote: > On Thu, 2011-09-15 at 02:35 -0500, Jeremy Huddleston wrote: > >> On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote: >>> >>> +if HAVE_XMLTO_TEXT >>> +noinst_DATA += $(docbook:.xml=.txt) >>> +%.txt: %.xml $(chapters) >>> + $(AM_V_GEN)$(XMLTO) $(XMLTO_HTML_FLAGS) txt $< >>> +endif HAVE_XMLTO_TEXT >> >> ^^^ XMLTO_TEXT_FLAGS ?? >> >> > > Good observation. The txt format is obtained by first transforming xml > to html using the same xsltproc and stylesheet. Then it is converted to > text using one of the three tools w3m, lynks or links. Although > confusing, it is more accurate to use the same html flags. It also looks > strange to have olink flags when you cannot have cross-reference > documents between text file. > > So this one is good, there were no lack of opportunities for errors. > > Thanks > _______________________________________________ > <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>: X.Org development > Archives: <A HREF="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</A> > Info: <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> <BR> </BODY> </HTML>