<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2">
</HEAD>
<BODY>
On Thu, 2011-09-15 at 02:23 -0500, Jamey Sharp wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#3c3c3c">On Wed, Sep 14, 2011 at 08:17:45PM -0500, Jeremy Huddleston wrote:</FONT></TT><BR>
<TT><FONT COLOR="#737373">> This makes a difference on darwin (and apparently nowhere else)</FONT></TT><BR>
<TT><FONT COLOR="#737373">> </FONT></TT><BR>
<TT><FONT COLOR="#737373">> Signed-off-by: Jeremy Huddleston <<A HREF="mailto:jeremyhu@apple.com">jeremyhu@apple.com</A>></FONT></TT><BR>
<TT><FONT COLOR="#737373">> ---</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#3c3c3c">According to the libtool manual, "modules that can be dlopened" need</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">libtool's -module switch. So I think this patch is the right thing to do</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">even if it doesn't make any difference on the platforms that already</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">supported the xfree86 DDX.</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#3c3c3c"><A HREF="https://www.gnu.org/s/libtool/manual/libtool.html#Modules-for-libltdl">https://www.gnu.org/s/libtool/manual/libtool.html#Modules-for-libltdl</A></FONT></TT><BR>
<BR>
<TT><FONT COLOR="#3c3c3c">Therefore:</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#3c3c3c">Reviewed-by: Jamey Sharp <<A HREF="mailto:jamey@minilop.net">jamey@minilop.net</A>></FONT></TT><BR>
<BR>
<TT><FONT COLOR="#3c3c3c">But I'd also like to hear from Gaetan or somebody on this as well.</FONT></TT><BR>
</BLOCKQUOTE>
<BR>
I have little hands-on experience with libraries, so I tried my google luck. I did find posts that confirms what Jeremy is saying. On the MAC, a module and a shared library is different. I found a post where the converse happened. A shared library was linked to using -module and it failed.
<BLOCKQUOTE>
<PRE>
Yea, GnuCash's previous developers wanted gnucash to be a bunch of Loadable
Modules.. But they never finished the modularlization, and they didn't
understand the difference between a Shared Library and a Loadable Module.
</PRE>
</BLOCKQUOTE>
A couple of things to verify:
<UL>
<LI>OpenBSD still uses libtool 1.5
<LI>Solaris is different enough to get a review for this
<LI>Ensure -module is not used for shared libraries (if makefile flags are shared)
</UL>
<BR>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca><BR>
<BLOCKQUOTE TYPE=CITE>
<BR>
<TT><FONT COLOR="#3c3c3c">Jamey</FONT></TT>
</BLOCKQUOTE>
</BODY>
</HTML>