<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2">
</HEAD>
<BODY>
On Sat, 2011-08-27 at 19:35 +0200, Rafał Mużyło wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#3c3c3c">First a minor nitpick about "Use AM_YFLAGS and BUILT_SOURCES rather than</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">EXTRA_DIST" patch:</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">while BUILT_SOURCES is probably the correct solution there, AM_YFLAGS</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">are redundant, it's already handled elsewhere.</FONT></TT><BR>
<BR>
<BR>
</BLOCKQUOTE>
When not using "AM_YFLAGS = -d", laygram.h is not included in the tarball, but still generated. Building the tarball on a computer when yacc is not installed produces this error:
<BLOCKQUOTE>
<PRE>
make[1]: *** No rule to make target `laygram.h', needed by `all'. Stop.
</PRE>
</BLOCKQUOTE>
The yacc package is not required to build a tarball as the generated code is included in the said tarball, so laygram.h must be included.<BR>
<BR>
This target is missing in the makefile, so it does not work on a git build either.
<BLOCKQUOTE>
<PRE>
laygram.h: laygram.c
@if test ! -f $@; then \
rm -f laygram.c; \
$(MAKE) $(AM_MAKEFLAGS) laygram.c; \
else :; fi
</PRE>
</BLOCKQUOTE>
<BR>
Thanks for mentioning this, I had not gone to that level of details yet.
</BODY>
</HTML>