<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2">
</HEAD>
<BODY>
On Tue, 2011-07-05 at 09:47 +1000, Peter Hutterer wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Fri, Jul 01, 2011 at 06:04:28AM -0700, Dan Nicholson wrote:
> On Thu, Jun 30, 2011 at 10:01 AM, Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>> wrote:
> > This reverts commit 4005df66072ceac175ea71427deb16176262f197.
> >
> > The patch introduces a couple of issues.
> > 1) These tools are apps and conceptually do not depend on Xserver,
> > so XORG_CFLAGS should not be used. It included pixman header files.
> > Only drivers depend xserver
>
> This is not true here. synclient includes <xserver-properties.h> so it
> can use the input properties designated by the server.
As I understand, this is handled by the -I$(sdkdir) in the patch (instead of
$XORG_CFLAGS). Having said this, the dependency on the header can easily be
removed.
</PRE>
</BLOCKQUOTE>
That's the reason for -I$(sdkdir) rather than XORG_CFLAGS. In previous patches reviewers<BR>
have commented that XORG_CFLAGS should not be used for tools.<BR>
<BR>
Having seen Peter's patch, it's great to remove the dependency on xserver_properties.<BR>
It will be much clearer now.
<BLOCKQUOTE TYPE=CITE>
<PRE>
Cheers,
Peter
> I don't see a
> reason to revert this patch. It seems to have good fixes in it.
</PRE>
</BLOCKQUOTE>
<BR>
</BODY>
</HTML>