<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Wed, 2011-03-23 at 23:29 -0400, Matt Turner wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Fixes: <A HREF="http://bugs.gentoo.org/show_bug.cgi?id=360227">http://bugs.gentoo.org/show_bug.cgi?id=360227</A>
Problem is easily seen during compile:
-DDFLT_XKB_CONFIG_ROOT='""/usr/share/X11/xkb""'
</PRE>
</BLOCKQUOTE>
This is what I get on Ubuntu before the patch:
<PRE>
-DDFLT_XKB_CONFIG_ROOT=\"/home/nadon/xorg/src/share/X11/xkb\"
</PRE>
Is this a platform difference?<BR>
<BR>
With the patch I get:
<BLOCKQUOTE>
<PRE>
-DDFLT_XKB_CONFIG_ROOT='/home/nadon/xorg/src/share/X11/xkb'
</PRE>
</BLOCKQUOTE>
but I also get:
<BLOCKQUOTE>
<PRE>
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../src -I../../include -I../../src -I/home/nadon/xorg/src/include -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -Wbad-function-cast -Wformat=2 -Wold-style-definition -Wdeclaration-after-statement -DDFLT_XKB_CONFIG_ROOT=/home/nadon/xorg/src/share/X11/xkb -g -O2 -fvisibility=hidden -MT listing.lo -MD -MP -MF .deps/listing.Tpo -c listing.c -fPIC -DPIC -o .libs/listing.o
listing.c: In function ‘xkb_list_components’:
listing.c:494: error: expected expression before ‘/’ token
listing.c:494: error: too few arguments to function ‘GenerateComponent’
</PRE>
</BLOCKQUOTE>
<BR>
What are your results before/after the patch?<BR>
<BR>
<BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
---
src/xkbcomp/Makefile.am | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xkbcomp/Makefile.am b/src/xkbcomp/Makefile.am
index db54c55..84e5381 100644
--- a/src/xkbcomp/Makefile.am
+++ b/src/xkbcomp/Makefile.am
@@ -1,6 +1,6 @@
AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/src
AM_CFLAGS = $(X11_CFLAGS) $(CWARNFLAGS) \
- -DDFLT_XKB_CONFIG_ROOT='"$(XKBCONFIGROOT)"'
+ -DDFLT_XKB_CONFIG_ROOT='$(XKBCONFIGROOT)'
noinst_LTLIBRARIES = libxkbcomp.la
libxkbcomp_la_SOURCES = \
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>