<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Tue, 2011-03-22 at 11:56 +1000, Peter Hutterer wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Signed-off-by: Peter Hutterer <<A HREF="mailto:peter.hutterer@who-t.net">peter.hutterer@who-t.net</A>>
---
I'll squash this in with the other patch, no need to have two separate ones.
test/Makefile.am | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
</PRE>
</BLOCKQUOTE>
Now that I have cleared some of my misunderstandings, there is little benefits<BR>
in using XORG_ENABLE_UNIT_TESTS for such a simple case,<BR>
unless you foresee a more complex situation in the short term.<BR>
But nothing wrong in using it either. It helps establishing a pattern.<BR>
<BR>
Using the check_PROGRAMS pattern would most likely ease maintenance and reduce<BR>
the risk of errors as it would work like most/all other modules.<BR>
<BR>
If there is a need to build the test program in the regular build, it could be moved<BR>
to the eventcomm dir. The test dir would simply make use of it. There is no obligation<BR>
for programs to be built in the test dir. <BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
diff --git a/test/Makefile.am b/test/Makefile.am
index 16502ee..0b45a2d 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -1,3 +1,4 @@
+if ENABLE_UNIT_TESTS
AM_CPPFLAGS = -I$(top_srcdir)/src
AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS)
fake_syms = fake-symbols.c fake-symbols.h
@@ -10,6 +11,5 @@ eventcomm_test_SOURCES = eventcomm-test.c\
$(fake_syms)
endif
-if ENABLE_UNIT_TESTS
TESTS = $(noinst_PROGRAMS)
endif
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>