<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Tue, 2011-03-22 at 09:54 +1000, Peter Hutterer wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#1a1a1a">IIRC, the main reason we have disable-unit-tests is because we chose glib as</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">testing suite and that wasn't available on all platforms. One thing we get</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">in the server now is commits that fix build issues in the tests because few</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">people build (or run) the tests.</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">note that glib isn't used here, so there's little reason to disable the unit</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">tests.</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">I'd rather have the build enabled by default, if not the test run itself.</FONT></TT><BR>
</BLOCKQUOTE>
The building is enabled by default, I don't understand why you think it isn't.<BR>
<BLOCKQUOTE TYPE=CITE>
<BR>
</BLOCKQUOTE>
I think there is some confusion. What prompted my comment is that I noticed the fact that<BR>
if I configure the module:
<BLOCKQUOTE>
<PRE>
./configure --disable-unit<TT>-tests</TT>
</PRE>
</BLOCKQUOTE>
the unit test program will still build (but it will not run). I don't know if it is right or wrong,<BR>
but it is not consistent with what others module did. Distro builders may appreciate having<BR>
the ability to skip building all in-tree unit tests by issuing this single configure option to all modules.<BR>
<BR>
The default value for XORG_ENABLE_UNIT_TESTS is "auto", which in this context is always "yes".<BR>
So the unit test will always build unless explicitly configured not to. I was just surprised to<BR>
see in the makefile that the code ensures that the unit test program can never ever be prevented<BR>
from building.
<BLOCKQUOTE>
<PRE>
# XORG_ENABLE_UNIT_TESTS (enable_unit_tests=auto)
# Interface to module:
# ENABLE_UNIT_TESTS: used in makefiles to conditionally build tests
# enable_unit_tests: used in configure.ac for additional configuration
# --enable-unit-tests: 'yes' user instructs the module to build tests
# 'no' user instructs the module not to build tests
# parm1: specify the default value, yes or no.
</PRE>
</BLOCKQUOTE>
<BR>
Note that the default (auto/yes/no) can be set in configure.ac:<BR>
XORG_ENABLE_UNIT_TEST(no) It may be useful in some other modules.
</BODY>
</HTML>