<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Mon, 2011-03-07 at 14:25 -0800, Dan Nicholson wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Mon, Mar 07, 2011 at 04:45:25PM -0500, Peter Harris wrote:
> On 2011-03-07 15:29, Dan Nicholson wrote:
> >
> > There are other components that use xcb-util, though. For instance,
> > xlsclients needs xcb-atom.pc from xcb-util. Probably it should be
> > included in the katamari.
>
> xlsclients was just (today) patched to remove its dependency on the
> deprecated xcb-atom exported atoms[1]. I believe that's all it depended
> on from xcb-atom.
>
> Someone with more autofoo than I could modify the xlsclients build to
> not depend on xcb-atom.pc.
Oh, right. See patch below for xlsclients.
--
Dan
>From 262e24324d1788026ae7f8715066825b0d6668d8 Mon Sep 17 00:00:00 2001
From: Dan Nicholson <<A HREF="mailto:dbn.lists@gmail.com">dbn.lists@gmail.com</A>>
Date: Mon, 7 Mar 2011 14:21:09 -0800
Subject: [PATCH] Drop dependency on xcb-atom/xcb-util
With commit 223851b6, the atom names from xcb/xproto.h are being used
and xcb-atom is no longer needed.
Signed-off-by: Dan Nicholson <<A HREF="mailto:dbn.lists@gmail.com">dbn.lists@gmail.com</A>>
---
configure.ac | 2 +-
xlsclients.c | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 39204e8..987ca2b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -45,7 +45,7 @@ fi
XORG_DEFAULT_OPTIONS
# Checks for pkg-config packages
-PKG_CHECK_MODULES(XLSCLIENTS, xcb xcb-atom)
+PKG_CHECK_MODULES(XLSCLIENTS, xcb)
AC_CONFIG_FILES([
        Makefile
diff --git a/xlsclients.c b/xlsclients.c
index 15d3f1a..691f868 100644
--- a/xlsclients.c
+++ b/xlsclients.c
@@ -37,7 +37,6 @@ in this Software without prior written authorization from The Open Group.
#include <inttypes.h>
#include <xcb/xcb.h>
#include <xcb/xproto.h>
-#include <xcb/xcb_atom.h>
#ifndef HAVE_STRNLEN
#include "strnlen.h"
#endif
</PRE>
</BLOCKQUOTE>
<BR>
<BR>
Reviewed-by: Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>><BR>
<BR>
That answers why xcb-util has always been in tinderbox and build.sh.<BR>
<BR>
Note that the new xcb-* repos use git submodules. It looks like jhbuild<BR>
already handles that.<BR>
<BR>
Anyone willing to honor the request in the xcb-util README?
<BLOCKQUOTE>
<PRE>
"If you find any of these libraries useful, please let us know what
you're using and why you aren't in a mental hospital yet".
</PRE>
</BLOCKQUOTE>
:-)<BR>
<BR>
<BR>
<BR>
<BR>
<BR>
<BR>
</BODY>
</HTML>