<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Sat, 2011-02-19 at 17:53 -0200, Fernando Tarlá Cardoso Lemos wrote: <BLOCKQUOTE TYPE=CITE> <PRE> Recent versions of GCC ship with a linker that doesn't add the deps of the DSOs to the linking process. This behavior is also found in GNU gold. This change fixes building with those linkers. Some references: <A HREF="http://wiki.debian.org/ToolChain/DSOLinking">http://wiki.debian.org/ToolChain/DSOLinking</A> <A HREF="https://fedoraproject.org/wiki/UnderstandingDSOLinkChange">https://fedoraproject.org/wiki/UnderstandingDSOLinkChange</A> --- configure.ac | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 39a3655..e22aa43 100644 --- a/configure.ac +++ b/configure.ac @@ -79,6 +79,9 @@ AM_CONDITIONAL(HAVE_ARC4RANDOM, test x$HAVE_ARC4RANDOM = xyes) # Function crypt() comes from the C library or the -lcrypt data encryption library AC_SEARCH_LIBS(crypt, crypt) + +# Function dl() comes from the C library or -ldl +AC_SEARCH_LIBS([dlopen], [dl]) #------------------------------------------------------------------------------ # Checks for header files. </PRE> </BLOCKQUOTE> Libtool (we still support v 1.5), is initialized with AC_LIBTOOL_DLOPEN. It does check for -ldl but it does not add it to LIBS. configure:10876: checking for dlopen configure:10932: gcc -o conftest -g -O2   conftest.c  >&5 /tmp/ccOqrtkL.o: In function `main': /home/nadon/xorg/src/app/xdm/conftest.c:61: undefined reference to `dlopen' collect2: ld returned 1 exit status configure:10939: $? = 1 <BLOCKQUOTE> <PRE> configure:10959: result: no configure:10964: checking for dlopen in -ldl configure:10999: gcc -o conftest -g -O2   conftest.c -ldl   >&5 configure:11006: $? = 0 configure:11027: result: yes </PRE> </BLOCKQUOTE> With the DSO linker, it would no longer work if I understand. This is why libdl needs to be added to LIBS as it cannot use dlopen indirectly from other libraries it links to. Have you checked there is no issue with adding this to BSD/MAC/Solaris systems? I would guess it cannot hurt. Thanks for the comment in the code and placing it in the appropriate section. Consider adding something like (needed by DSO linker) if this is correct. It might prevent someone from removing it as duplicate code. Reviewed-by: Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>> </BODY> </HTML>