<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Sat, 2011-01-29 at 03:31 +0100, Cyril Brulebois wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Otherwise, ./configure returns successfully while xkbparse.lo can fail
to build due to a missing include:
| YACC xkbparse.c
| CC xkbparse.lo
| xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory
Signed-off-by: Cyril Brulebois <<A HREF="mailto:kibi@debian.org">kibi@debian.org</A>>
---
configure.ac | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 0026441..d8db8fd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -66,7 +66,7 @@ if test "x$CC_FOR_BUILD" = x; then
fi
# Obtain protocols headers include directives
-PKG_CHECK_MODULES([X11], [xproto kbproto >= 1.0.5])
+PKG_CHECK_MODULES([X11], [x11 xproto kbproto >= 1.0.5])
</PRE>
</BLOCKQUOTE>
<BR>
Reviewed-by: <TT><FONT COLOR="#1a1a1a">Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>></FONT></TT><BR>
<BR>
You may want to ensure this is reviewed by one the authors of this lib.<BR>
I recall some readings putting emphasis on the fact that the library did not<BR>
depend on libX11. <BR>
<BR>
This commit <A HREF="http://cgit.freedesktop.org/xorg/lib/libxkbcommon/commit/?id=8d2c522f3156c3381d8530ce2346d1ec84fafe8d">http://cgit.freedesktop.org/xorg/lib/libxkbcommon/commit/?id=8d2c522f3156c3381d8530ce2346d1ec84fafe8d</A><BR>
says: "Don't check for xlib, we don't need it"<BR>
<BR>
Maybe this include is not necessary or there is an alternate solution to not depend on X11.<BR>
<BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
# Obtain the path to the X Window System Core Protocol
AC_MSG_CHECKING([for X11 includedir])
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>