<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Fri, 2011-01-21 at 20:07 +0100, Cyril Brulebois wrote: <BLOCKQUOTE TYPE=CITE> <PRE> HAVE_LIBDRM comes from config.h, so include it first. With CFLAGS="-Wall -Werror", the build fails with: | CC vmware_drv_la-vmwaremodule.lo | cc1: warnings being treated as errors | vmwaremodule.c: In function ‘vmware_check_kernel_module’: | vmwaremodule.c:100: error: implicit declaration of function ‘drmOpen’ | vmwaremodule.c:112: error: implicit declaration of function ‘drmClose’ Signed-off-by: Cyril Brulebois <<A HREF="mailto:kibi@debian.org">kibi@debian.org</A>> --- src/vmwaremodule.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vmwaremodule.c b/src/vmwaremodule.c index a7ba854..2754879 100644 --- a/src/vmwaremodule.c +++ b/src/vmwaremodule.c @@ -26,14 +26,14 @@ #include <xorg-server.h> #include <xf86.h> -#ifdef HAVE_LIBDRM -#include <xf86drm.h> -#endif - #ifdef HAVE_CONFIG_H #include "config.h" #endif +#ifdef HAVE_LIBDRM +#include <xf86drm.h> +#endif + #ifndef HAVE_XORG_SERVER_1_5_0 #include <xf86_ansic.h> #include <xf86_libc.h> -- 1.7.2.3 </PRE> </BLOCKQUOTE> This is the correct order. Reviewed-by: <TT>Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>></TT> I have copied the driver maintainer who will review and potentially push the patch. <A HREF="http://www.x.org/wiki/vmware">http://www.x.org/wiki/vmware</A> <BLOCKQUOTE TYPE=CITE> <PRE> _______________________________________________ <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>: X.Org development Archives: <A HREF="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</A> Info: <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> </BODY> </HTML>