<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> You're right. This was caused by a sloppy fix by me for another problem. I'll revert that fix tomorrow and try to find a correct fix for that problem. /Thomas On 01/21/2011 10:57 PM, Gaetan Nadon wrote: <blockquote cite="mid:1295647054.12297.464.camel@ubuntu" type="cite"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta name="GENERATOR" content="GtkHTML/3.26.0"> On Fri, 2011-01-21 at 20:07 +0100, Cyril Brulebois wrote: <blockquote type="CITE"> <pre>HAVE_LIBDRM comes from config.h, so include it first. With CFLAGS="-Wall -Werror", the build fails with: | CC vmware_drv_la-vmwaremodule.lo | cc1: warnings being treated as errors | vmwaremodule.c: In function ‘vmware_check_kernel_module’: | vmwaremodule.c:100: error: implicit declaration of function ‘drmOpen’ | vmwaremodule.c:112: error: implicit declaration of function ‘drmClose’ Signed-off-by: Cyril Brulebois <<a moz-do-not-send="true" href="mailto:kibi@debian.org">kibi@debian.org</a>> --- src/vmwaremodule.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vmwaremodule.c b/src/vmwaremodule.c index a7ba854..2754879 100644 --- a/src/vmwaremodule.c +++ b/src/vmwaremodule.c @@ -26,14 +26,14 @@ #include <xorg-server.h> #include <xf86.h> -#ifdef HAVE_LIBDRM -#include <xf86drm.h> -#endif - #ifdef HAVE_CONFIG_H #include "config.h" #endif +#ifdef HAVE_LIBDRM +#include <xf86drm.h> +#endif + #ifndef HAVE_XORG_SERVER_1_5_0 #include <xf86_ansic.h> #include <xf86_libc.h> -- 1.7.2.3 </pre> </blockquote> This is the correct order. Reviewed-by: <tt>Gaetan Nadon <<a moz-do-not-send="true" href="mailto:memsize@videotron.ca">memsize@videotron.ca</a>></tt> I have copied the driver maintainer who will review and potentially push the patch. <a moz-do-not-send="true" href="http://www.x.org/wiki/vmware">http://www.x.org/wiki/vmware</a> <blockquote type="CITE"> <pre>_______________________________________________ <a moz-do-not-send="true" href="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</a>: X.Org development Archives: <a moz-do-not-send="true" href="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</a> Info: <a moz-do-not-send="true" href="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</a> </pre> </blockquote> </blockquote> </body> </html>