<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Tue, 2011-01-04 at 09:42 +1000, Peter Hutterer wrote: <BLOCKQUOTE TYPE=CITE> <TT>> +check_writable_dir () {</TT> <TT>> +    if [ X"$SUDO" = X ]; then</TT> <TT>skip this check, just because it's sudo doesn't mean you can write to</TT> <TT>the directory.</TT> </BLOCKQUOTE> On the other hand, without this test, a user running build.sh with -s <sudo> will always erroneously have the error message if he has write permission only with sudo. The script aborts and there is no workaround. With the (not fool proof) test for sudo, running: <BLOCKQUOTE> <PRE> $SUDO env LD_LIBRARY_PATH=$LD_LIBRARY_PATH ${MAKE} $MAKEFLAGS install </PRE> </BLOCKQUOTE> will fail if the user does not have write permission. This is what we have today, no early detection. Either I accept that early detection is not always possible, or I remove the function all together. <BLOCKQUOTE TYPE=CITE> <TT>also, for readability, you may want to add a line of </TT> <TT>dir="$1"</TT> <TT>and then use $dir instead of $1 in the remainder.</TT> </BLOCKQUOTE> Agreed <BLOCKQUOTE TYPE=CITE> <TT>Cheers,</TT> <TT>  Peter</TT> <TT>> +     if [ ! -d "$1" ] || [ ! -w "$1" ]; then</TT> <TT>> +         echo "The path \"$1\" supplied by \"$2\" must be a writable directory"</TT> <TT>> +         echo ""</TT> <TT>> +         usage</TT> <TT>> +         exit 1</TT> <TT>> +     fi</TT> <TT>> +    fi</TT> <TT>> +}</TT> </BLOCKQUOTE> </BODY> </HTML>