<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Mon, 2010-12-20 at 08:56 -0500, Adam Jackson wrote: <BLOCKQUOTE TYPE=CITE> <TT>The ones I pushed hadn't been nacked, I didn't think?  Regardless, yeah,</TT> <TT>revert.</TT> </BLOCKQUOTE> Correct. A number of similar patches were posted within a 6 day period with various reviewers responding to various patches. That leaves one patch for which I posted a revert and would appreciate a review. <A HREF="http://lists.x.org/archives/xorg-devel/2010-December/017299.html">http://lists.x.org/archives/xorg-devel/2010-December/017299.html</A> My main concern is introducing 2 ways of exporting/hiding symbols that are far apart (Makefile and source code). It's just error prone. Other libraries use _X_EXPORT and _X_HIDDEN and we should stick to this method, even if a "one liner in the makefile" appears to be a short term gain. Thanks Gaetan </BODY> </HTML>