<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Fri, 2010-12-17 at 08:35 -0500, Trevor Woerner wrote: <BLOCKQUOTE TYPE=CITE> <PRE> The following commit in lib/libXdmcp: commit b64cac63e0bcdd87bbfd19678552fd7ed1a3b58f Author: Cristian RodrÃguez <<A HREF="mailto:cristian.rodriguez@opensuse.org">cristian.rodriguez@opensuse.org</A>> Date: Tue Dec 14 15:40:20 2010 -0500 Export only public API symbols Reviewed-by: Adam Jackson <<A HREF="mailto:ajax@redhat.com">ajax@redhat.com</A>> Signed-off-by: Cristian RodrÃguez <<A HREF="mailto:cristian.rodriguez@opensuse.org">cristian.rodriguez@opensuse.org</A>> Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find the following symbols: _XdmcpAuthSetup _XdmcpAuthDoIt      _XdmcpWrapperToOddParity </PRE> </BLOCKQUOTE> I don't understand why this patch, and a few other similar ones, were pushed as they were Nacked by 4 reviewers. They should be reverted and redone properly. The problem that occurred is exactly what happens when relying on a naming convention. Sooner or later it will break. All other libraries do it in the source code. Gaetan <BLOCKQUOTE TYPE=CITE> <PRE> _______________________________________________ <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>: X.Org development Archives: <A HREF="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</A> Info: <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> </BODY> </HTML>