<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Sun, 2010-11-21 at 00:05 -0800, Jesse Adkins wrote: <BLOCKQUOTE TYPE=CITE> <TT>> What I should have been suggesting is to use $(AM_V_at) as it is used in</TT> <TT>> several places in the server already.</TT> <TT>></TT> <TT>> hw/xfree86/Makefile.in:       $(AM_V_at)rm -f Xorg && $(MAKE) Xorg</TT> <TT>></TT> <TT>Should this fix be applied to the other driver patches as well? It</TT> </BLOCKQUOTE> Yes <BLOCKQUOTE TYPE=CITE> <TT>seems like a v2 for this patch set is probably going to be needed at</TT> <TT>some point. The commit message is cryptic,</TT> </BLOCKQUOTE> The sentence Matt wrote would be sufficient to inform future generations. <BLOCKQUOTE TYPE=CITE> <TT> the input drivers don't use</TT> <TT>moduledir, and some drivers install multiple .so files.</TT> <TT>I certainly wouldn't mind, since most of the work could be easily</TT> <TT>automated. </TT> </BLOCKQUOTE> I thought so, that's why I provided my feedback as early as possible, at the cost of being a bit disorganized. I am done reviewing, I can't think of anything else. <BLOCKQUOTE TYPE=CITE> <TT>Even if it were not, I'd like to make sure that this is</TT> <TT>100% complete so this bug can be closed for good.</TT> </BLOCKQUOTE> </BODY> </HTML>