<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Mon, 2010-11-01 at 16:34 -0700, Jeremy Huddleston wrote: <BLOCKQUOTE TYPE=CITE> <TT>So... basically what I said originally... ? ;)</TT> </BLOCKQUOTE> End result is the same. I failed to recognize this  level of indirection: <BLOCKQUOTE> <PRE> <TT>XORG_CWARNFLAGS would be updated to call these two and set </TT> <TT>CWARNFLAGS="$(CFLAGS_WARNINGS) $(CFLAGS_NO_STRICT_ALIASING)"</TT> </PRE> </BLOCKQUOTE> This has nice advantages, and will help with the conversion so as long as XORG_CWARNFLAGS is set back to it's original value eventually. The reason is that somewhere in the future, either <TT>CFLAGS_WARNINGS</TT> or <TT>CFLAGS_NO_STRICT_ALIASING</TT> could get changed. This would unfortunately change the value of XORG_CWARNFLAGS still used in previous versions of modules or in modules outside the X.Org "in the wild". By not touching XORG_CWARNFLAGS at all, we eliminate any risk, not to mention possible confusion. Once this point is settled, a patch can be submitted for review, along with a plan for converting modules. Thanks! Gaetan </BODY> </HTML>