<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Fri, 2010-10-22 at 14:07 -0400, Trevor Woerner wrote: <BLOCKQUOTE TYPE=CITE> <TT>From: Trevor Woerner <<A HREF="mailto:twoerner@gmail.com">twoerner@gmail.com</A>></TT> <TT>For those using 'gmake' instead of 'make'.</TT> <TT>Signed-off-by: Trevor Woerner <<A HREF="mailto:twoerner@gmail.com">twoerner@gmail.com</A>></TT> </BLOCKQUOTE> <PRE> Reviewed-by: <TT>Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>></TT> Suggestion for a follow-on patch. There is an assumption that make, git and now gmake are present on the system. This is not always the case. This is what I get when running 'gmake': </PRE> <BLOCKQUOTE> <PRE> util/modular/build.sh: 1152: gmake: not found [...] ***** gmake failed on util/macros error processing module/component:  "util/macros" </PRE> </BLOCKQUOTE> And this is what I get when running 'bogus': <BLOCKQUOTE> <PRE> $ util/modular/build.sh -o util/macros --cmd bogus /home/nadon/xorg/src The script can only process 'make', 'gmake', or 'git' commands It can't process 'bogus' commands </PRE> </BLOCKQUOTE> Just thinking out loud here, maybe we should accept any command, so as long as it exists. Checking `which some_cmd` should be enough. This allows user to run any script they want. I haven't thought it through. </BODY> </HTML>