<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Wed, 2010-10-06 at 17:14 -0700, Jeremy Huddleston wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#1a1a1a">Signed-off-by: Jeremy Huddleston <<A HREF="mailto:jeremyhu@apple.com">jeremyhu@apple.com</A>></FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">---</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> Makefile.am | 2 +-</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> configure.ac | 7 ++++---</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> 2 files changed, 5 insertions(+), 4 deletions(-)</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">diff --git a/Makefile.am b/Makefile.am</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">index 34d9819..f1fc0cc 100644</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">--- a/Makefile.am</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+++ b/Makefile.am</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">@@ -36,7 +36,7 @@ FONT_FILES = \</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> fontdir = @FONTDIR@</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> font_DATA = $(FONT_FILES)</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> </FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">-fontconfigdir = $(sysconfdir)/fonts</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+fontconfigdir = @FC_CONFDIR@</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> actualconfigdir = $(fontconfigdir)/conf.d</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> availconfigdir = $(fontconfigdir)/conf.avail</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> dist_availconfig_DATA = 42-luxi-mono.conf</FONT></TT><BR>
<BR>
</BLOCKQUOTE>
<BR>
Reviewed-by: <TT><FONT COLOR="#1a1a1a">Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>></FONT></TT><BR>
<BR>
Just a nit, it could be simplified:
<BLOCKQUOTE>
<PRE>
actualconfigdir = $(FC_CONFDIR)/conf.d
availconfigdir = $(FC_CONFDIR)/conf.avail
</PRE>
</BLOCKQUOTE>
There is no need to define a variable with the "dir" suffix as something<BR>
like fontconfig_DATA is not used. It's nice to keep the variables with dir suffix<BR>
for those who participate in the Automake "uniform naming scheme".<BR>
<BR>
<BR>
</BODY>
</HTML>