<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Tue, 2010-10-05 at 10:55 +0200, Julien Cristau wrote: <BLOCKQUOTE TYPE=CITE> <TT>> $ util/modular/build.sh $PREFIX --cmd "git pull"</TT> <TT>> </TT> <TT>> Would you consider it an example of having built every</TT> <TT>> module/component? It isn't strictly correct anymore to say the only</TT> <TT>> thing build.sh can do is build items. "can only be processed" is a</TT> <TT>> more general and correct phrase to explain the operation of build.sh.</TT> <TT>> </TT> <TT>> Although, since it's not strictly a spelling correction, the two</TT> <TT>> should probably be submitted as separate patches.</TT> <TT>You can do git pull on any OS, the only thing you can't do everywhere is</TT> <TT>build the driver.</TT> </BLOCKQUOTE> There is an ambiguity here. New functions have been added, so the script can do things that aren't strictly building. On other hand, this is a "build" script. It's main purpose in life is to "build" the software. Added functions are accessories to "building". The reason why there are case statements is because the software won't build on the specified platforms, not because it cannot be downloaded or even configured. Using "process", being more abstract, can claim to be more correct, it cannot claim to be more useful. I would stick with the current comment as I think is the one that will be the most useful to readers. It won't matter to 99% of users if the Sun legacy video driver can be downloaded on a MAC. I am in the 1% as I work mostly on configuration, so I don't care if it builds or not on my platform. Ideally, for me, there should be an option to by-pass the platform check. I have pushed the 3 patches in the first series. <TT>[PATCH modular 1/3] Sanity check required cmdline arguments.</TT> <TT>[PATCH modular 2/3] Add extra check for 'prefix'.</TT> <TT>[PATCH modular 3/3] Better cmdline error parsing.</TT> I suggest a new series be posted which takes into account the feedback received so far for: <TT>[PATCH modular 1/3] Process a user-supplied list of module/components.</TT> <TT>[PATCH modular 2/3] Fix spelling.</TT> <TT>[PATCH modular 3/3] Enable progress on git clone.</TT> This will make easier for reviewers. </BODY> </HTML>