<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Thu, 2010-09-30 at 17:26 -0400, Trevor Woerner wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#1a1a1a">From: Trevor Woerner <<A HREF="mailto:twoerner@gmail.com">twoerner@gmail.com</A>></FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">Place into one location the logic to decide what to do with regards to</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">the following build modes: LISTONLY, RESUME, NOQUIT, and BUILD_ONE.</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">Signed-off-by: Trevor Woerner <<A HREF="mailto:twoerner@gmail.com">twoerner@gmail.com</A>></FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">---</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> build.sh | 163 ++++++++++++++++++++++++++++++++++++++++++++------------------</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> 1 files changed, 116 insertions(+), 47 deletions(-)</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#1a1a1a">diff --git a/build.sh b/build.sh</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">index 3a57561..2bfcebb 100755</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">--- a/build.sh</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+++ b/build.sh</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">@@ -66,12 +66,8 @@ nonexistent_components=""</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> clonefailed_components=""</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> </FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> failed() {</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">- if [ X"${NOQUIT}" != X ]; then</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">- echo "***** $1 failed on $2/$3"</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">- failed_components="$failed_components $2/$3"</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">- else</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">- exit 1</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">- fi</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ echo "***** $1 failed on $2/$3"</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ failed_components="$failed_components $2/$3"</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> }</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> </FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> # print a pretty title to separate the processing of each module</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">@@ -147,12 +143,18 @@ checkfortars() {</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> if [ X"$jj" = X"gz" ]; then</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> TAROPTS=xzf</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a"> fi</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">- tar $TAROPTS $TARFILE -C $ii || failed tar $1 $2</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ tar $TAROPTS $TARFILE -C $ii</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ if [ $? -ne 0 ]; then</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ failed tar $1 $2</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ return 1</FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">+ fi</FONT></TT><BR>
<BR>
</BLOCKQUOTE>
I got distracted by this "return 1" change and there are quite a few of them.<BR>
Could you split the patch to take this change out of way as it does not match the commit text.<BR>
It would significantly reduce the size of the main patch.<BR>
<BR>
A random example where the code change is not related to (but of course, necessary) to<BR>
the code mission of the patch. I know it's not always possible, I am not sure in this case, that's why I ask.<BR>
<BR>
<BR>
<BR>
</BODY>
</HTML>