<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Sun, 2010-08-08 at 05:23 -0500, Yaakov (Cygwin/X) wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
From: Yaakov Selkowitz <<A HREF="mailto:yselkowitz@users.sourceforge.net">yselkowitz@users.sourceforge.net</A>>
Using LN_S is required for portability; on MinGW, this is "cp -p".
The install-exec-hook in src/Makefile.am must remain !PLATFORM_WIN32,
as Windows cannot resolve DLL runtime dependencies from symlinks.
Signed-off-by: Yaakov Selkowitz <<A HREF="mailto:yselkowitz@users.sourceforge.net">yselkowitz@users.sourceforge.net</A>>
---
Makefile.am | 4 +---
configure.ac | 1 +
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 412aefc..5eed6e3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -31,10 +31,8 @@ EXTRA_DIST =                  \
        old-doc/Changelog \
        old-doc/CHANGES
-if !PLATFORM_WIN32
install-exec-hook:
-        cd $(DESTDIR)$(libdir) && rm -f libXaw.@LIBEXT@ && ln -s $(DEFAULT_LIB) libXaw.@LIBEXT@
-endif
+        cd $(DESTDIR)$(libdir) && rm -f libXaw.@LIBEXT@ && $(LN_S) $(DEFAULT_LIB) libXaw.@LIBEXT@
.PHONY: ChangeLog INSTALL
diff --git a/configure.ac b/configure.ac
index 84f21d4..47f2215 100644
--- a/configure.ac
+++ b/configure.ac
@@ -54,6 +54,7 @@ platform_darwin=no
LIBEXT=so
case $host_os in
cygwin*|mingw*)
+        LIBEXT=dll.a
        platform_win32=yes
        ;
darwin*)
</PRE>
</BLOCKQUOTE>
<BR>
Acked-by: <TT><FONT COLOR="#1a1a1a">Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>></FONT></TT><BR>
<BR>
It would be preferable to do the LN_S change in a separate patch as it distract from the core changes.<BR>
Is the library extension renaming part of the exec-hook? Why does it have to change?<BR>
I had a hard time understand the creative explanation "must remain !PLATFORM_WIN32".<BR>
Perhaps something like "must be done on all platforms including WIN32".<BR>
<BR>
These nits are magnified as I am not familiar with the platform.<BR>
One more thing, which isn't related to your path, does the "clean" and "uninstall" target work correctly, given the<BR>
work done in the exec hook?<BR>
<BR>
Gaetan<BR>
<BR>
<BR>
</BODY>
</HTML>