<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Fri, 2010-05-14 at 06:35 -0700, Dan Nicholson wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Wed, May 12, 2010 at 10:11 AM, Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>> wrote:
> Compiling this BSD file under Linux finds errors in conditional code.
> PCCONS is undefined and should be protected with PCCONS_SUPPORT
Why would the bsd sources get compiled on linux?
</PRE>
</BLOCKQUOTE>
To simulate a bsd system that does not have PCCONS support.<BR>
<BR>
In xserver config at line 426,<BR>
<BR>
<BLOCKQUOTE>
<PRE>
*openbsd*)
AC_DEFINE(CSRG_BASED, 1, [System is BSD-like])
AC_DEFINE(PCVT_SUPPORT, 1, [System has PC console])
AC_DEFINE(WSCONS_SUPPORT, 1, [System has wscons console])
;
</PRE>
</BLOCKQUOTE>
there is no PCCONS_SUPPORT. I don't have a running openbsd system, I can only guess what the situation can be at the moment:<BR>
<BR>
1- If openbsd does in fact not support PCCONS, the code fails to compile<BR>
2- If openbsd does in fact support PCCONS and xserver fails to set PCCONS_SUPPORT, a new fix is required.<BR>
<BR>
Any insight into this is welcome. I'll update the commit msg.<BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
>
> Signed-off-by: Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>>
> ---
> src/bsd_kbd.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c
> index bc80692..8575ab2 100644
> --- a/src/bsd_kbd.c
> +++ b/src/bsd_kbd.c
> @@ -88,8 +88,10 @@ SetKbdLeds(InputInfoPtr pInfo, int leds)
>
> switch (pKbd->consType) {
>
> +#if defined (PCCONS_SUPPORT)
This and the others can use the simpler "#ifdef PCCONS_SUPPORT" like
later in SoundBell.
</PRE>
</BLOCKQUOTE>
Yes they can.
<BLOCKQUOTE TYPE=CITE>
<PRE>
--
Dan
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>