<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Mon, 2010-04-19 at 09:58 +1000, Peter Hutterer wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Sat, Apr 17, 2010 at 07:28:00PM -0400, Gaetan Nadon wrote:
> Patch #1 concept has been reviewed but code is different
> Patch #7 is a change that has not been reviewed in other patches yet.
> Other changes have been reviewed in other patches
>
> Gaetan Nadon (10):
> config: remove AH_TOP autoheader statement
> config: update AC_PREREQ statement to 2.60
> replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS
> config: remove unrequired AC_HEADER_STDC
> config: refactor and comment the sdkdir distcheck workaround
> config: replace deprecated INCLUDES with AM_CPPFLAGS
> config: optional extension check for inputproto not required
> config: fix warnings, m4 quoting and layout
> include: EXTRA_DIST is not required for header files.
> man: Use Autoconf provided $(AM_V_GEN)$(SED)
>
> Makefile.am | 2 +-
> configure.ac | 63 ++++++++++++++++++++++++--------------------------
> include/Makefile.am | 1 -
> man/Makefile.am | 4 +--
> src/Makefile.am | 3 +-
> src/evdev.c | 1 +
> 6 files changed, 34 insertions(+), 40 deletions(-)
Reviewed-by: Peter Hutterer <<A HREF="mailto:peter.hutterer@who-t.net">peter.hutterer@who-t.net</A>>
except for that one comment I sent separately. Can you pop this into your
$HOME please and I'll pull from there. Want to get a few test runs in before
it lands on master, just in case.
</PRE>
</BLOCKQUOTE>
Peter,<BR>
<BR>
Done. Other input drivers have similar changes.In some cases, I am not certain of what is the best option:<BR>
<BR>
--enable-debug: there are 3 input drivers and one video driver with this config option. I am not sure this should be exposed on the package public interface if only used by x.org developers at development time. If it's a good thing, perhaps it should be on all drivers. Many video drivers have a *DEBUG* kind of #define, but no configure option, The actual name varies. I guess there is no architected way of turning debug on several packages using the same method.<BR>
<BR>
joystick: the enable-debug option is always "on" by default. Very unusual.<BR>
<BR>
aiptek/evdev only runs Linux while joystick runs on Linux/BSD. Should these be conditional compiled so as to build on any platform? If they were part of xserver, they would have to be. <BR>
<BR>
<BR>
====================================================================
<BLOCKQUOTE>
<PRE>
The following changes since commit aaf65e7bfacd9501c4475a579d92c3bc60409893:
Paulo Ricardo Zanoni (1):
Don't set pEvdev->rel for mouse wheel events
are available in the git repository at:
git://people.freedesktop.org/~gnadon/xf86-input-evdev master
Gaetan Nadon (10):
config: remove AH_TOP autoheader statement
config: update AC_PREREQ statement to 2.60
replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS
config: remove unrequired AC_HEADER_STDC
config: refactor and comment the sdkdir distcheck workaround
config: replace deprecated INCLUDES with AM_CPPFLAGS
config: optional extension check for inputproto not required
config: require macros 1.4, fix warnings, m4 quotings and layout
include: EXTRA_DIST is not required for header files.
man: Use Autoconf provided $(AM_V_GEN)$(SED)
Makefile.am | 2 +-
configure.ac | 63 ++++++++++++++++++++++++--------------------------
include/Makefile.am | 1 -
man/Makefile.am | 4 +--
src/Makefile.am | 3 +-
src/evdev.c | 1 +
6 files changed, 34 insertions(+), 40 deletions(-)
</PRE>
</BLOCKQUOTE>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
thanks!
Cheers,
Peter
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>