<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Wed, 2010-03-24 at 08:53 +0100, Rémi Cardona wrote: <BLOCKQUOTE TYPE=CITE> <PRE> Le 24/03/2010 07:21, Yaakov (Cygwin/X) a écrit : > From: Yaakov Selkowitz <<A HREF="mailto:yselkowitz@users.sourceforge.net">yselkowitz@users.sourceforge.net</A>> > > We now use libtool, which calls AC_PROG_SED and sets SED as the path to > a fully-functional 'sed' (which may also be called 'gsed' if GNU sed is > installed alongside a proprietary version). Therefore we should respect > this value of SED so we are sure to use the correct one. Then configure should still call AC_PROG_SED explicitely. Relying on libtool's macros for that _will_ bite us at some point. The rest of the patch is fine. </PRE> </BLOCKQUOTE> I agree AC_PROG_SED and similar macros should be explicitly called. This alerts the reader that the program in question is used, so it also has a documentation benefit. It's of a great help to find where env variables are defined. <BLOCKQUOTE TYPE=CITE> <PRE> Cheers, Rémi _______________________________________________ <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>: X.Org development Archives: <A HREF="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</A> Info: <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> </BODY> </HTML>