<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Tue, 2010-03-09 at 14:09 -0800, Alan Coopersmith wrote: <BLOCKQUOTE TYPE=CITE> <PRE> They're separate there since that was one of the modules I'd actually added lint support to, and lint needs the -I/-D flags that are passed in CPPFLAGS, but not the -W/-v flags from CWARNFLAGS. -alan- </PRE> </BLOCKQUOTE> I had just glanced over the LINT target, but I'll dig into it. I had considered separating options between AM_CFLAGS and AM_CPPFLAGS in modules, but xorg-server from pc file contains -fvisibility=hidden tangled with includes. There are 33 modules with a LINT target. I was in the process of removing the obsolete INCLUDES Automake variable (due to a warning) but I had not noticed it was used in lint. Thanks <BLOCKQUOTE TYPE=CITE> <PRE> Gaetan Nadon wrote: > It's more for consistency with other modules. > > Signed-off-by: Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>> > --- > src/Makefile.am | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/src/Makefile.am b/src/Makefile.am > index 0857c98..ec18c5c 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -18,8 +18,7 @@ > # IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > # CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > -AM_CFLAGS = $(CWARNFLAGS) > -AM_CPPFLAGS = $(XORG_CFLAGS) > +AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS) > > # this is obnoxious: > # -module lets us name the module exactly how we want </PRE> </BLOCKQUOTE> </BODY> </HTML>