<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:st1="urn:schemas-microsoft-com:office:smarttags" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]--><o:SmartTagType
namespaceuri="urn:schemas-microsoft-com:office:smarttags" name="chsdate"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="chmetcnv"/>
<o:SmartTagType namespaceuri="urn:schemas-microsoft-com:office:smarttags"
name="PersonName"/>
<!--[if !mso]>
<style>
st1\:*{behavior:url(#default#ieooui) }
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 3 0 0 0 0 0 0 0;}
@font-face
{font-family:MingLiU;
panose-1:2 2 3 9 0 0 0 0 0 0;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:PMingLiU;
panose-1:2 2 3 0 0 0 0 0 0 0;}
@font-face
{font-family:MingLiU;
panose-1:2 2 3 9 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:PMingLiU;}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:blue;
text-decoration:underline;}
pre
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:MingLiU;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:Arial;
color:navy;}
@page Section1
{size:595.3pt 841.9pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=ZH-TW link=blue vlink=blue>
<div class=Section1>
<p class=MsoNormal><font size=1 color=navy face=Arial><span lang=EN-US
style='font-size:9.0pt;font-family:Arial;color:navy'>Hi Gaetan,<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=1 color=navy face=Arial><span lang=EN-US
style='font-size:9.0pt;font-family:Arial;color:navy'>It might be caused by our
editing source code on Windows platform.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=1 color=navy face=Arial><span lang=EN-US
style='font-size:9.0pt;font-family:Arial;color:navy'>It might be fixed by
convert files by dos2unix.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=1 color=navy face=Arial><span lang=EN-US
style='font-size:9.0pt;font-family:Arial;color:navy'>How about your comment?<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=1 color=navy face=Arial><span lang=EN-US
style='font-size:9.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face=新細明體><span lang=EN-US style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span lang=EN-US
style='font-size:10.0pt;font-family:Tahoma;font-weight:bold'>From:</span></font></b><font
size=2 face=Tahoma><span lang=EN-US style='font-size:10.0pt;font-family:Tahoma'>
xorg-devel-bounces@lists.x.org [mailto:xorg-devel-bounces@lists.x.org] <b><span
style='font-weight:bold'>On Behalf Of </span></b>Gaetan Nadon<br>
<b><span style='font-weight:bold'>Sent:</span></b> Monday, January 25, 2010 9:43
PM<br>
<b><span style='font-weight:bold'>To:</span></b> <st1:PersonName
ProductID="Jong Lin" w:st="on">Jong Lin</st1:PersonName><br>
<b><span style='font-weight:bold'>Cc:</span></b> <st1:PersonName w:st="on">xorg-devel@lists.x.org</st1:PersonName><br>
<b><span style='font-weight:bold'>Subject:</span></b> Re: [PATCH video-xgi] Add
Support-ARM, EXA acceleration, EDID,Custom Modes, Bugs fixed, ...</span></font><span
lang=EN-US><o:p></o:p></span></p>
</div>
<p class=MsoNormal><font size=3 face=新細明體><span
lang=EN-US style='font-size:12.0pt'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=3 face=新細明體><span
lang=EN-US style='font-size:12.0pt'>On Mon, <st1:chsdate IsROCDate="False"
IsLunarDate="False" Day="25" Month="1" Year="2010" w:st="on">2010-01-25</st1:chsdate>
at 16:29 +0800, <st1:PersonName ProductID="Jong Lin" w:st="on">Jong Lin</st1:PersonName>
wrote: <o:p></o:p></span></font></p>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3 color=navy
face=新細明體><span lang=EN-US style='font-size:12.0pt;
color:navy'>This patch includes the following enhancements and some bug
fixings.</span></font><span lang=EN-US><br>
<br>
<font color=navy><span style='color:navy'>(1). Support ARM</span></font><br>
<br>
<font color=navy><span style='color:navy'>(2). Support EXA acceleration</span></font><br>
<br>
<font color=navy><span style='color:navy'>(3). Support EDID with I<st1:chmetcnv
TCSC="0" NumberType="1" Negative="False" HasSpace="False" SourceValue="2"
UnitName="C" w:st="on">2C</st1:chmetcnv> function</span></font><br>
<br>
<font color=navy><span style='color:navy'>(4). Support Custom Modes of modeline</span></font><br>
<br>
<font color=navy><span style='color:navy'>(5). Unify code for x86, PowerPC, ARM</span></font><br>
<br>
<o:p></o:p></span></p>
<p class=MsoNormal><font size=3 face=新細明體><span
lang=EN-US style='font-size:12.0pt'><br>
I used 'git apply --check' to verify the patch would apply but it doesn't I get
errors like:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=3 face=新細明體><span
lang=EN-US style='font-size:12.0pt'>error: patch failed: src/init.c:1 <o:p></o:p></span></font></p>
<pre><font size=3 face=細明體><span lang=EN-US
style='font-size:12.0pt'><o:p> </o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>error: src/init.c: patch does not apply<o:p></o:p></span></font></pre>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3 face=新細明體><span
lang=EN-US style='font-size:12.0pt'>The patch shows that the whole content of
the init.c file has changed, but I can't see any real code difference. Then I
remembered about code page issues when translators worked from different
platforms (Unix, Windows...). I checked the file with the 'file' command:<o:p></o:p></span></font></p>
<pre><font size=3 face=細明體><span lang=EN-US
style='font-size:12.0pt'><o:p> </o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>init.c: ASCII C program text, with CRLF line terminators<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>vb_ext.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>vb_init.c: ASCII C program text, with CRLF line terminators<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>vb_setmode.c: ASCII C program text, with CRLF line terminators<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_accel.c: ASCII C program text, with CRLF line terminators<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_cursor.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_dac.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_dga.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_dri.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_driver.c: ASCII C program text, with CRLF, LF line terminators<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_opt.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_setup.c: ASCII C program text, with CRLF, LF line terminators<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_vb.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_vga.c: ASCII C program text, with CRLF line terminators<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_video.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'>xgi_videohw.c: ASCII C program text<o:p></o:p></span></font></pre><pre><font
size=3 face=細明體><span lang=EN-US style='font-size:12.0pt'><o:p> </o:p></span></font></pre>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3 face=新細明體><span
lang=EN-US style='font-size:12.0pt'>It just so happens that the files giving
errors are the one with CRLF terminators. Most likely, xgi developers edit code
on platforms having different file formats. I did a quick scan on other drivers
and I have not seen files with CRLF terminators.<br>
<br>
It's just a theory for now, most likely others have seen this before and know
of to fix it.<br>
<br>
<o:p></o:p></span></font></p>
</div>
</body>
</html>