<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Mon, 2010-01-25 at 20:15 +0200, Tiago Vignatti wrote: <BLOCKQUOTE TYPE=CITE> <PRE> On Fri, Jan 22, 2010 at 11:18:20PM +0100, ext Gaetan Nadon wrote: > On Fri, 2010-01-22 at 19:04 +0200, Tiago Vignatti wrote: > > if test "x$DRI" = xyes || test "x$DRI2" = xyes; then > - PKG_CHECK_MODULES([LIBDRM], $LIBDRM) > - AC_SUBST(LIBDRM_CFLAGS) > - AC_SUBST(LIBDRM_LIBS) > + if test "x$DRM" = xyes; then > + AC_DEFINE(WITH_LIBDRM, 1, [Building with libdrm support]) > + PKG_CHECK_MODULES([LIBDRM], $LIBDRM) > + AC_SUBST(LIBDRM_CFLAGS) > + AC_SUBST(LIBDRM_LIBS) > > > nit: AC_SUBST not required, already done by PKG_CHECK_MODULES > Are you sure about it? If so, we need to patch all configure.ac doing such correction. </PRE> </BLOCKQUOTE> Yes, you can easily look in the generated Makefile. I tried both with and without the AC_SUBST. LIBDRM_CFLAGS = -I/home/nadon/xorg/src/include -I/home/nadon/xorg/src/include/drm  LIBDRM_LIBS = -L/home/nadon/xorg/src/lib -ldrm  Macro definitions: <BLOCKQUOTE> <PRE> AC_DEFUN([PKG_CHECK_MODULES], [AC_REQUIRE([PKG_PROG_PKG_CONFIG])dnl AC_ARG_VAR([$1][_CFLAGS], [C compiler flags for $1, overriding pkg-config])dnl AC_ARG_VAR([$1][_LIBS], [linker flags for $1, overriding pkg-config])dnl ... </PRE> <BLOCKQUOTE> <PRE> AC_DEFUN([AC_ARG_VAR], ... AC_SUBST([$1])dnl _AC_ARG_VAR_PRECIOUS([$1])dnl ])# AC_ARG_VAR </PRE> </BLOCKQUOTE> </BLOCKQUOTE> The macro from pkg-config defines the LIBDRM_CFLAGS and LIBDRM_LIBS as arguments to ./configure. In doing so, AC_ARG_VAR calls AC_SUBST so that you are able to use it in your makefile. I have a todo to clean them up, that would make one less to do. The extra statements don't hurt, remove them only if you are satisfied. <BLOCKQUOTE TYPE=CITE> <PRE> Thanks, Tiago </PRE> </BLOCKQUOTE> </BODY> </HTML>