<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Fri, 2010-01-08 at 08:37 -0800, Dan Nicholson wrote: <BLOCKQUOTE TYPE=CITE> <PRE> On Fri, Jan 8, 2010 at 8:32 AM, Julien Cristau <<A HREF="mailto:jcristau@debian.org">jcristau@debian.org</A>> wrote: > On Fri, Jan  8, 2010 at 08:26:14 -0800, Dan Nicholson wrote: > >> This seems to have dropped the -I$(top_srcdir)/src that was being >> mangled in in configure. Is that still needed? >> > It seemed to build fine without it, so I left it out. </PRE> </BLOCKQUOTE> Just a reminder to run 'make distcheck' for that type of changes. It exercises the paths in a different way as the build dir isn't the same as the source dir. In some cases, the order of includes is important when a header file is in multiple locations. Thanks for fixing this.<BR> <BR> <BLOCKQUOTE TYPE=CITE> <PRE> Yeah, none of the headers in there seem like they're needed outside of that directory. None of them get installed, either, so you wouldn't be picking up your system copy if you were missing the -I. Reviewed-by: Dan Nicholson <<A HREF="mailto:dbn.lists@gmail.com">dbn.lists@gmail.com</A>> -- Dan _______________________________________________ xorg-devel mailing list <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A> <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> </BODY> </HTML>