<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> Resending. On Thu, 2009-12-17 at 19:48 -0500, Gaetan Nadon wrote: <BLOCKQUOTE TYPE=CITE> Hi, There are 41 driver modules with the line: <BLOCKQUOTE> <TT>sdkdir=$(pkg-config --variable=sdkdir xorg-server)</TT> </BLOCKQUOTE> Following up on review <A HREF="http://lists.x.org/archives/xorg-devel/2009-November/003711.html">http://lists.x.org/archives/xorg-devel/2009-November/003711.html</A> <BLOCKQUOTE> <TT>From Dan Nicholson:</TT> <TT>This should be</TT> <TT>sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`</TT> <TT>1. The user may need to use a specific pkg-config or pass custom</TT> <TT>arguments to it. Think multiarch or cross-compiling scenarios.</TT> <TT>2. Backticks (``) are supported by all shells while $() command</TT> <TT>substitution is for strictly POSIX conforming shells. We don't need to</TT> <TT>limit ourselves to that subset.</TT> </BLOCKQUOTE> There are 35 modules who are not using that line at all. Rather than making dead code more portable, this patch removes this statement. I have done extensive grepping and tested with make distcheck: acecad, aiptek, keyboard, mouse, vmmouse, ast, ati, chips, cirrus, dummy, fbdev, geode, i128, i740 neomagic, newport, nv, rendition, s3, s3virge, siliconmotion, sisusb suncg3, suncg6, suncg14, sunffb, sunleo, suntcx, tga, trident, tseng, v4l vmware, voodoo, wsfb I intend to apply this patch to all 35 of them. Other patches for the remainder modules will follow. The reference patch is from video-ati <PRE> _______________________________________________ xorg-devel mailing list <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A> <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> </BODY> </HTML>