<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Tue, 2009-10-20 at 14:48 -0700, Jeremy Huddleston wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Here it was removed from pixman yesterday:
<A HREF="http://cgit.freedesktop.org/pixman/commit/?id=9bcfc0ac547277d3a3f4e5ff0922450566ad8be8">http://cgit.freedesktop.org/pixman/commit/?id=9bcfc0ac547277d3a3f4e5ff0922450566ad8be8</A>
</PRE>
</BLOCKQUOTE>
Thanks. Pixman also does not specify AM_MAINTAINER_MODE, so it is consistent. The maintainer mode is enable. I did a git build and created a tarball. I extracted the tarball, built it and ran 'make maintainer-clean'. I was able to rebuild the tarball which means there is no danger to run this target and no need to disable it.<BR>
<BR>
If this was the intended behaviour, then all is fine. As for the modules in git xorg/ I would first check with release management before changing the current behaviour as there is a project wide consistency issue. <BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Oct 20, 2009, at 14:01, Gaetan Nadon wrote:
>
> This option is in use in 259 out of 261 X.Org, mesa and xcb modules. I
> do not know the history behind this option, but there is no sign of
> deprecation in the Autoconf docs.
>
> It overrides the default value provided by AM_MAINTAINER_MODE in
> configure.ac which disables MAINTAINERCLEAN list. This allows git
> builds
> to clean files in this list but does not allow (by default) the
> tarball
> builder to do the same. If a tarball builder runs 'make
> maintainer-clean', he may or may not be able to rebuild the tarball.
>
> Removing the option alone will disable the maintainer-clean target for
> both git builds and tarballs. Removing both the option and the
> AM_MAINTAINER_MODE will allow maintainer-clean for both git builds and
> tarballs.
>
> maintainer-clean-generic:
> @echo "This command is intended for maintainers to use"
> @echo "it deletes files that may require special tools to
> rebuild."
> maintainer-clean: maintainer-clean-am
> -rm -f $(am__CONFIG_DISTCLEAN_FILES)
> -rm -rf $(top_srcdir)/autom4te.cache
> -rm -f Makefile
> maintainer-clean-am: distclean-am maintainer-clean-generic
>
>
>
>
>
>
> On Tue, 2009-10-20 at 12:29 -0700, Jeremy Huddleston wrote:
>
>> Shouldn't we be nuking all the "--enable-maintainer-mode" in
>> autogen.sh now... or do we still want to support the older
>> toolchains? I thought I saw a commit fly by a few days ago nuking
>> that from a module.
>>
>> On Oct 20, 2009, at 10:17, Jon TURNEY wrote:
>>
>>> ---
>>> autogen.sh | 11 ++++++++++-
>>> 1 files changed, 10 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/autogen.sh b/autogen.sh
>>> index d68a142..904cd67 100755
>>> --- a/autogen.sh
>>> +++ b/autogen.sh
>>> @@ -1,3 +1,12 @@
>>> #! /bin/sh
>>> +
>>> +srcdir=`dirname $0`
>>> +test -z "$srcdir" && srcdir=.
>>> +
>>> +ORIGDIR=`pwd`
>>> +cd $srcdir
>>> +
>>> autoreconf -v --install || exit 1
>>> -./configure "$@"
>>> +cd $ORIGDIR || exit $?
>>> +
>>> +$srcdir/configure --enable-maintainer-mode "$@"
>>> --
>>> 1.6.3.3
>>>
>>> _______________________________________________
>>> xorg-devel mailing list
>>> <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>
>>> <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A>
>>
>> _______________________________________________
>> xorg-devel mailing list
>> <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>
>> <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A>
> _______________________________________________
> xorg-devel mailing list
> <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>
> <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A>
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>