<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">On Oct 3, 2009, at 03:53, Michel Dänzer wrote:<br><br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">On Fri, 2009-10-02 at 18:25 -0700, Jeremy Huddleston wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">On Oct 2, 2009, at 16:17, Michel Dänzer wrote:<br><br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">On Fri, 2009-10-02 at 23:10 +0200, Martin Ettl wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote"><br>diff --git a/exa/exa_classic.c b/exa/exa_classic.c<br>index 1eff570..c9c7534 100644<br>--- a/exa/exa_classic.c<br>
+++ b/exa/exa_classic.c<br>@@ -144,14 +144,14 @@ Bool<br>exaModifyPixmapHeader_classic(PixmapPtr pPixmap, int width, int<br>height, int depth,<br> int bitsPerPixel, int devKind, pointer pPixData)<br>{<br>
+ if (!pPixmap)<br>+ return FALSE;<br>+<br> ScreenPtr pScreen = pPixmap->drawable.pScreen;<br> ExaScreenPrivPtr pExaScr;<br> ExaPixmapPrivPtr pExaPixmap;<br> Bool ret;<br><br>- if (!pPixmap)<br>- return FALSE;<br>
-<br> pExaScr = ExaGetScreenPriv(pScreen);<br> pExaPixmap = ExaGetPixmapPriv(pPixmap);<br><br></blockquote>...<br>Mixing code and declarations is a C99 feature, and I'm not sure we<br>require a C99 compiler yet. I'm not sure that that these tests serve<br>
any<br>real purpose, they can probably just be removed.<br></blockquote><br>Well, they serve a purpose, and I'd like to keep them in for sanity<br>purposes.<br></blockquote><br>What purpose is that? If these functions were actually called with a<br>
NULL PixmapPtr, surely the current code would have crashed with a<br>segmentation fault.</blockquote></blockquote>
<div class="gmail_quote"> </div>
<div class="gmail_quote">My experience is "don't change it unless you know it is broken". Gracefully returning a warning (FALSE) is better than making yourself (xserver) look bad (crashing). </div>
<div class="gmail_quote"> </div>
<div class="gmail_quote">Ping</div>