xserver: is ifdef DO_PROTOTYPES still needed ?

[Alan Coopersmith]

On 2/8/24 08:41, Enrico Weigelt, metux IT consult wrote:
> Hello folks,
> 
> 
> in compiler.h we've got huge block #ifdef'ed on DO_PROTOTYPES, but I
> can't find that be set anywhere. (if set, it defines some arch- and
> compiler specific prototypes)
> 
> Do we still need that ?

It is still set for building with the Sun compilers in compiler.h:
https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/compiler.h#L55

But as those compilers aren't supported by meson, and I don't plan on adding
support for them there, we could probably remove all the __SUNPRO_C #ifdefs
in the meson-only master branch now.  (The 21.x branch still supports building
with those compilers using autoconf though.)

 From using a 'git log -S DO_PROTOTYPES' in the xserver git repo, it
looks like the #define to use it with other compilers was removed by
commit 95bb6f53624a3e6 back in 2008.

-- 
         -Alan Coopersmith-                 alan.coopersmith at oracle.com
          Oracle Solaris Engineering - https://blogs.oracle.com/solaris