[PATCH] glx: fix regression with copy sub buffer disappearing

Adam Jackson ajax at nwnk.net
Wed Sep 23 14:10:18 PDT 2015


On Wed, 2015-09-23 at 11:19 +1000, Dave Airlie wrote:
> From: Fedora X Ninjas <x at fedoraproject.org>
> 
> So copy sub buffer isn't a core extensions it's a driver extension
> which means we are using totally the wrong interface to query for it
> here, which means bad things happen when you roll out this code,
> for instance MESA_copy_sub_buffer stops working.

I have vague memories of trying to find the extension in the driver ext
list and not seeing it, but that might have been a function of using a
stale Mesa version?

Whatever though.  This patch is fine, drisw doesn't generate GLX
protocol for this request so the server can go ahead and claim to
support it in all cases, the client will issue the appropriate blit.  I
agree it's not pretty, but that's true of drisw in general, a vgem
design would make this all properly moot.

Merged:

remote: I: patch #60153 updated using rev 6da3f5d04f6a1cda0c858280f9561f9fbc323275.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   5e9457c..6da3f5d  master -> master

- ajax


More information about the xorg-devel mailing list