[PATCH] composite: Don't bother copying the pixmap for ForgetGravity windows (v3)

Adam Jackson ajax at redhat.com
Thu Nov 19 07:16:37 PST 2015


On Wed, 2015-11-18 at 21:43 -0800, Keith Packard wrote:
> "Jasper St. Pierre" <jstpierre at mecheye.net> writes:
> 
> > +static Bool
> > +needsPixmapCopy(WindowPtr pWin)
> > +{
> > +    WindowPtr pChild;
> > +
> > +    if (pWin->bitGravity != ForgetGravity)
> > +        return TRUE;
> > +
> > +    for (pChild = pWin->firstChild; pChild; pChild = pChild->nextSib)
> > +        if (needsPixmapCopy(pChild))
> > +            return TRUE;
> > +
> > +    return FALSE;
> > +}
> 
> I think you can use TraverseTree here; that has the advantage of not
> being recursive.

I think this still needs to address what I wrote in paragraph 2 here:

http://lists.freedesktop.org/archives/xorg-devel/2015-May/046376.html

- ajax


More information about the xorg-devel mailing list