[PULL] glamor-next

[Eric Anholt]

Michel Dänzer <michel at daenzer.net> writes:

> On 26.03.2015 04:14, Eric Anholt wrote:
>> Michel Dänzer <michel at daenzer.net> writes:
>>> On 25.03.2015 05:21, Eric Anholt wrote:
>>>>
>>>> Keith Packard (13):
>>> [...]
>>>>       glamor: Eliminate GLAMOR_USE_SCREEN and GLAMOR_USE_PICTURE_SCREEN
>>>>       glamor: Remove _nf rendering functions
>>>>       glamor: Remove ddx fallback check functions
>>>
>>> NAK for these changes. I'll be using the *_nf functions in the radeon
>>> driver soon, and I expect there might be interest for something similar
>>> in the modesetting driver and/or Xwayland in the long term as well.
>> 
>> Can you elaborate on what you're planning on using them for?
>
> If it's really important to remove that stuff, there should be more
> justification than 'the intel driver no longer uses this', because it's
> still being used.

Well, it's 550 out of our only 19700 lines of code.  That's a pretty
good justification to me.

The only reason _nf is useful is if you need to implement faster
software fallbacks -- otherwise, you should wrap above glamor, since _nf
would have been equivalent to calling down.  What operations are falling
back that you need to be faster?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150325/a75effe6/attachment.sig>