[PATCH libXt] asprintf needs _GNU_SOURCE on some platforms

Daniel Stone daniel at fooishbar.org
Tue Jan 27 04:44:11 PST 2015


Hi,

On 26 January 2015 at 16:51, Rob Clark <robdclark at gmail.com> wrote:
> diff --git a/configure.ac b/configure.ac
> index 3633ec6..e60e88d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -66,7 +66,7 @@ fi
>  AC_SUBST([CC_FOR_BUILD])
>  DEFAULT_CPPFLAGS_FOR_BUILD="${CPPFLAGS}"
>  AC_CHECK_FUNC(asprintf,
> -  [DEFAULT_CPPFLAGS_FOR_BUILD="${DEFAULT_CPPFLAGS_FOR_BUILD} -DHAVE_ASPRINTF"])
> +  [DEFAULT_CPPFLAGS_FOR_BUILD="${DEFAULT_CPPFLAGS_FOR_BUILD} -DHAVE_ASPRINTF -D_GNU_SOURCE"])
>  CPPFLAGS_FOR_BUILD=${CPPFLAGS_FOR_BUILD-${DEFAULT_CPPFLAGS_FOR_BUILD}}
>  AC_SUBST(CPPFLAGS_FOR_BUILD)
>  DEFAULT_CFLAGS_FOR_BUILD="${CFLAGS} ${CWARNFLAGS}"

AC_USE_SYSTEM_EXTENSIONS is the canonical way to switch on all
GNU/BSD/POSIX/XOPEN/blah/etc extensions. This, somewhere, appears to
set AC__GNU_SOURCE, so it might be good to check for that and switch
it on where appropriate.

Cheers,
Daniel


More information about the xorg-devel mailing list