[PATCH:libXt 1/5] If CFLAGS_FOR_BUILD is not set, include CWARNFLAGS in default value

[Hans de Goede]

Hi,

The entire set looks good to me and is:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


On 19-01-15 19:41, Alan Coopersmith wrote:
> Help catch errors like missing prototypes in makestrs sooner.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>   configure.ac |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 1f95a5c..34e6aab 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -66,7 +66,8 @@ fi
>   AC_SUBST([CC_FOR_BUILD])
>   CPPFLAGS_FOR_BUILD=${CPPFLAGS_FOR_BUILD-${CPPFLAGS}}
>   AC_SUBST(CPPFLAGS_FOR_BUILD)
> -CFLAGS_FOR_BUILD=${CFLAGS_FOR_BUILD-${CFLAGS}}
> +DEFAULT_CFLAGS_FOR_BUILD="${CFLAGS} ${CWARNFLAGS}"
> +CFLAGS_FOR_BUILD=${CFLAGS_FOR_BUILD-${DEFAULT_CFLAGS_FOR_BUILD}}
>   AC_SUBST(CFLAGS_FOR_BUILD)
>   LDFLAGS_FOR_BUILD=${LDFLAGS_FOR_BUILD-${LDFLAGS}}
>   AC_SUBST(LDFLAGS_FOR_BUILD)
>