[PATCH:mkfontscale] Remove extraneous duplicate checks for -r & -n options

Hans de Goede hdegoede at redhat.com
Mon Jun 23 04:41:53 PDT 2014


Hi,

On 06/21/2014 08:26 AM, Alan Coopersmith wrote:
> Flagged by cppcheck 1.65:
> [mkfontscale.c:247]: (style) Expression is always false because
>  'else if' condition matches previous condition at line 224.
> [mkfontscale.c:245]: (style) Expression is always false because
>  'else if' condition matches previous condition at line 227.
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Looks good, nice cleanup:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans

> ---
>  mkfontscale.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/mkfontscale.c b/mkfontscale.c
> index 036a0b4..da93e0c 100644
> --- a/mkfontscale.c
> +++ b/mkfontscale.c
> @@ -242,10 +242,6 @@ main(int argc, char **argv)
>              }
>              bigEncodingFuzz = atof(argv[argn + 1]) / 100.0;
>              argn += 2;
> -        } else if (strcmp(argv[argn], "-r") == 0) { /* ignore for now */
> -	    argn++;
> -	} else if (strcmp(argv[argn], "-n") == 0) {
> -	    argn++;
>  	} else if (strcmp(argv[argn], "-v") == 0) {
>  	    printf("%s\n", PACKAGE_STRING);
>  	    exit(0);
> 


More information about the xorg-devel mailing list