[PATCH v2] mi: don't process events from disabled devices (#77884)

Jeremy Huddleston Sequoia jeremyhu at freedesktop.org
Thu Jun 5 20:41:36 PDT 2014


Introduces a build failure:

http://tinderbox.x.org/builds/2014-06-05-0001/logs/xserver/#build

mieq.c:520:9: error: void function 'mieqProcessDeviceEvent' should not return a value [-Wreturn-type,Semantic Issue]
        return 0;
        ^      ~
1 error generated.
make[1]: *** [mieq.lo] Error 1
make: *** [all-recursive] Error 1

Patch to follow.

On Jun 4, 2014, at 22:17, Keith Packard <keithp at keithp.com> wrote:

> Peter Hutterer <peter.hutterer at who-t.net> writes:
> 
>> Once a device is disabled, it doesn't have a sprite pointer anymore. If an
>> event is still in the queue and processed after DisableDevice finished, a
>> dereference causes a crash. Example backtrace (crash forced by injecting an
>> event at the right time):
> 
> Merged (with review).
>   e6f5d9d..9fb0831  master -> master
> 
> -- 
> keith.packard at intel.com
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel



More information about the xorg-devel mailing list