[PATCH libX11] Remove dead USE_OWN_COMPOSE-protected code

Alan Coopersmith alan.coopersmith at oracle.com
Sun Feb 16 17:07:30 PST 2014


On 02/11/14 07:06 AM, Julien Cristau wrote:
> On Tue, Feb 11, 2014 at 13:26:16 +0200, Ran Benita wrote:
>
>> The build doesn't provide any way to define this option. It also refers
>> to files (imComp.h) and functions (e.g. XimCompInitTables(),
>> XimCompProcessSym()) which are not found anywhere, and the ordinary
>> Compose implementation in xim doesn't use any of it.
>>
>> Signed-off-by: Ran Benita <ran234 at gmail.com>
>> ---
>>
>> Some archeology uncovers this was some proprietary SGI thing:
>>
>> http://cgit.freedesktop.org/~alanc/xc-historical/commit/xc/lib?id=5e0c3fb8ff8178c644b9b4ef5fc566683ab85b65
>> http://cgit.freedesktop.org/~libv/xfree86/commit/?id=f672e940f91aaaea21feb4395fcb4f7bd701a9a9
>> http://cgit.freedesktop.org/~libv/xfree86/commit/?id=452696362c65cbc2e1a28ebaf4cc3cda51768cdb
>> http://people.kth.se/~e96_coj/oopk_home/Compose.h
>>
>> Anyway it's definitely not needed anymore (if it ever was).
>>
>>   src/KeyBind.c     |  72 --------------------------------------
>>   src/xkb/XKBBind.c | 102 ------------------------------------------------------
>>   2 files changed, 174 deletions(-)
>>
> Reviewed-by: Julien Cristau <jcristau at debian.org>

Thanks, pushed:

remote: Updating patchwork state for 
http://patchwork.freedesktop.org/project/Xorg/list/
remote: I: patch #20003 updated using rev a6dcf2201a05adbff54122df05a1e6325936abb6.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/lib/libX11
    b64bee2..a6dcf22  master -> master

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list