[PATCH xorg-fonts] configure.ac: remove C compiler dependency

Alan Coopersmith alan.coopersmith at oracle.com
Mon Dec 15 16:54:21 PST 2014


On 12/12/14 09:43 AM, Richard Tollerton wrote:
> Font compilation does not require a C compiler, but configure will fail
> anyway if one isn't found, because of the inclusion of
> XORG_DEFAULT_OPTIONS. Fix this by including only those macros normally
> in XORG_DEFAULT_OPTIONS that don't ultimately bring in AC_PROG_CC.
>
> Signed-off-by: Richard Tollerton <rich.tollerton at ni.com>
> ---
>   configure.ac | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 5b5b3aa..1d6874a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -31,7 +31,9 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2])
>   m4_ifndef([XORG_MACROS_VERSION],
>   	  [m4_fatal([must install xorg-macros 1.3 or later before running autoconf/autogen])])
>   XORG_MACROS_VERSION(1.3)
> -XORG_DEFAULT_OPTIONS
> +XORG_RELEASE_VERSION
> +XORG_CHANGELOG
> +XORG_MANPAGE_SECTIONS

I do like the idea of skipping a lot of time-consuming compiler tests
when building those modules in a full build, but I'm not sure that's
the best way to do it.

Instead of undoing XORG_DEFAULT_OPTIONS and going back to updating every
configure script for every global change I'd rather we introduced into
xorg-macros either an argument to XORG_DEFAULT_OPTIONS to skip the calls
that set up compiler flags or have new macro that's the appropriate
subset of options for modules that don't use the compiler.

For instance, the above is missing XORG_INSTALL, AC_PROG_INSTALL, &
the setup of AM_SILENT_RULES which all are applied in current
XORG_DEFAULT_OPTIONS and are useful for fonts & similar modules.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list