[PATCH] dix: offset touch root coordinates by ScreenRec origins (#86655)

Peter Hutterer peter.hutterer at who-t.net
Thu Dec 11 14:29:43 PST 2014


On Thu, Dec 11, 2014 at 11:51:58AM -0800, Keith Packard wrote:
> Peter Hutterer <peter.hutterer at who-t.net> writes:
> 
> > For two ScreenRecs abs pointer positioning was working fine, but touch events
> > stuck to the lower/right edge on any screen but the one with a 0/0 origin.
> > Cause is a missing offset by the screen coordinates, causing the root
> > coordinates in the event to desktop-wide, not screen-wide.
> 
> GetKeyboardEvents, GetDixTouchEnd also call event_set_root_coordinates
> without adjusting the device coordinates. Are those also wrong?

GetKeyboardEvents should drop the valuator mask bits anyway. No open driver
uses them and I'm pretty sure nothing in there works as expected anyway.

GetDixTouchEnd is a different story. Looks like it needs to be offset but I
need to find a test case for that first.

Cheers,
   Peter




More information about the xorg-devel mailing list