[PATCH libX11 1/2] xcb_io: Fix Xlib 32-bit request number wrapping

[Jonas Petersen]

Am 17.11.2013 20:20, schrieb Mouse:
>> I guess the sizeof comparison would not be necessary since the
>> condition should never meet with 64-bit longs.
> Unless it's in a code fragment that's used only on machines with
> <64-bit longs, it will; X runs on systems with 64-bit longs.
I meant the condition "dpy->request < dpy->xcb_last_flushed" should not 
meet on systems with 64-bit longs (at least not until the 64-bit wrap). 
So the "sizeof(uint64_t) > sizeof(unsigned long)" would not be 
necessary. It would just increase the overhead on <64-bit systems.

>
>> And if it does, something is wrong anyway (from my understanding).
>> After all this is the trigger of the bug.
> Does anyone know whether the bug triggers on systems with 64-bit longs?

I would say no, because there is no 32-bit to wrap. But who knows, I 
have not tried it.

- Jonas