[PATCH xsetmode] Remove dead code the-l option

Peter Hutterer peter.hutterer at who-t.net
Tue Jul 9 21:17:35 PDT 2013


On Tue, Jul 09, 2013 at 10:41:42AM +0200, Thomas Klausner wrote:
> On Mon, Jul 08, 2013 at 11:53:56PM -0700, Alan Coopersmith wrote:
> > On 07/ 8/13 03:55 PM, Stéphane Aulery wrote:
> > >Remove dead code the-l option that seems copied from another utility
> > >(xsetpointer) but never executed.
> > >
> > >Signed-off-by: Stéphane Aulery <lkppo at free.fr>
> > >---
> > >  xsetmode.c |   14 ++------------
> > >  1 file changed, 2 insertions(+), 12 deletions(-)
> > 
> > Dead code in a dead program.   Pushed, though like xsetpointer, it's
> > not had a release since X11R7.0.
> > 
> > Hopefully no distros are still shipping these - it only takes 5 minutes
> > to publish a release if there's need, but if no one has done that since
> > 2005, it's hard to claim there's demand for it.
> 
> We still have it in pkgsrc. If you give me a good reason I can remove
> it. Like: what is the replacement, or why is it completely unneeded.

xsetmode still works on devices that support multiple mode, the hooks are
still there so functionally there's nothing wrong with it. xinput has
replaced it though, you get the same with
  xinput --set-mode "device name" ABSOLUTE
since xinput is actively maintained, I recommend using that instead.

xsetpointer sets an input device as the core pointer. This dates back to
when an extension device could not be a core device at the same time and is
obsolete since server 1.4 (2006 or so I think). the request always fails
now (96e32805d12fc36f0fa0926dbfb0dd8a5cadb739).
xinput set-pointer is the equiv xsetpointer, but still doesn't do anything,
that app is truly dead.

Cheers,
   Peter


More information about the xorg-devel mailing list