[PATCH] DDX/DPMS: Call dixSaveScreens() also when screen is turned on

Keith Packard keithp at keithp.com
Tue Aug 13 03:52:29 PDT 2013


Egbert Eich <eich at freedesktop.org> writes:

> DMPS calls dixSaveScreens() when turned off but not when turned
> on. In most cases this is irrelevant as DPMS is done when a
> key is hit in which case dixSaveScreens() will be called to
> unblank anyhow. This isn't the case if we use xset (or the
> DPMS extension directly) to unblank.

This is going to call dixSaveScreens twice in the 'usual' case, which
may not be what we want, but we clearly need to call dixSaveScreens
every time DPMSSet is called.

So, what we have is that when the DPMS code turns the monitor off,
dixSaveScreens is always called, but dixSaveScreens can also be called
in other cases, leaving us with the situation where the event processing
code may call dixSaveScreens in some cases where it does not call the
DPMS code, so we cannot simply remove the dixSaveScreens call from the
event code and add it to the DPMS code.

Yuck.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130813/fa39f9a6/attachment.pgp>


More information about the xorg-devel mailing list