[PATCH] Fix FP1616 macro

Daniel Martin consume.noise at gmail.com
Wed Oct 31 04:26:14 PDT 2012


This one looked that obvious that I was not sure and had to verify it
with a small test. ;)

The macro is used with frac != 0 in to places, only. Maybe that's why
nobody noticed that mistake before:

1. dix/eventconvert.c
    ...
    EventToXI2()
      ...
      case ET_TouchEnd:
          return eventToDeviceEvent()
      ...
    ...
    eventToDeviceEvent()
      ...
      xde->root_x = FP1616(ev->root_x, ev->root_x_frac);
      xde->root_y = FP1616(ev->root_y, ev->root_y_frac);
      ...
    ...

2. test/xi2/protocol-eventconvert.c
    ...
    test_values_XIDeviceEvent()
      ...
      assert(out->root_x == FP1616(in->root_x, in->root_x_frac));
      assert(out->root_y == FP1616(in->root_y, in->root_y_frac));
      ...
    ...


Cheers,

Daniel Martin (1):
  Fix FP1616 macro

 include/eventconvert.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.0



More information about the xorg-devel mailing list