[PATCH synaptics] Revert "Don't store fake events in the motion history"

Chase Douglas chase.douglas at canonical.com
Mon Feb 20 02:41:20 PST 2012


On 02/20/2012 01:20 AM, Peter Hutterer wrote:
> This commit introduced a regression. On some touchpads, the pointer keeps
> moving in the last direction when the finger movement stops but the finger
> is left on the touchpad.
> 
> Cause appears to be get_delta() which calculates the deltas based on the
> motion history but has no control flow for the lack of fake motion events
> in the history after this commit. Thus, under some conditions, the delta is
> always non-zero as the history does not change.
> 
> Reproducer attached to bug
> https://bugs.freedesktop.org/show_bug.cgi?id=45278#c11
> 
> X.Org Bug 45278 <http://bugs.freedesktop.org/show_bug.cgi?id=45278>
> 
> This reverts commit c8b098214b44cf0585d78c460401ea7d143769f3.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> There is probably a more extensive fix, starting with figuring out why the
> timer still fires after enough movement to adding hooks for ignoring the
> motion history if we're from a timer. This requires more time that I have
> available atm.

I don't really understand what the original change was for. Why do we
care if fake events are stored in the history or not? It seems logical
to me that we want to store fake events, and reverting the change fixes
a bug so...

Reviewed-by: Chase Douglas <chase.douglas at canonical.com>


More information about the xorg-devel mailing list